Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that WithParams keeps the transport #15421

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Ensure that WithParams keeps the transport #15421

merged 1 commit into from
Mar 7, 2024

Conversation

dbussink
Copy link
Contributor

@dbussink dbussink commented Mar 7, 2024

Not having a transport means we get crash here which we should avoid.

Related Issue(s)

Fixes #15419

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

@dbussink
Ensure that WithParams keeps the transport
60c162f 
Not having a transport means we get crash here which we should avoid.

Signed-off-by: Dirkjan Bussink <[email protected]>
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Mar 7, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Mar 7, 2024
@dbussink dbussink removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Mar 7, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Mar 7, 2024
mattlord
mattlord approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@mattlord mattlord mentioned this pull request Mar 7, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.74%. Comparing base (6c73053) to head (60c162f).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15421      +/-   ##
==========================================
+ Coverage   65.72%   65.74%   +0.01%     
==========================================
  Files        1563     1563              
  Lines      194027   194027              
==========================================
+ Hits       127529   127559      +30     
+ Misses      66498    66468      -30

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frouioui
Copy link
Member

frouioui commented Mar 7, 2024

Backporting this to v19 as the bug was found on the v19.0.0 release

@frouioui frouioui merged commit 66f1990 into vitessio:main Mar 7, 2024
114 of 115 checks passed
@frouioui frouioui deleted the dbussink/with-params-transport branch March 7, 2024 17:16
vitess-bot pushed a commit that referenced this pull request Mar 7, 2024
@vitess-bot
Ensure that WithParams keeps the transport (#15421)
c1b79c2 
Signed-off-by: Dirkjan Bussink <[email protected]>
@vitess-bot vitess-bot bot mentioned this pull request Mar 7, 2024
Merged
dbussink pushed a commit that referenced this pull request Mar 7, 2024
@vitess-bot
[release-19.0] Ensure that WithParams keeps the transport (#15421) (#…
3ce870d 
…15422)

Signed-off-by: Dirkjan Bussink <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
@marf
Copy link

marf commented Mar 13, 2024

Hello, has the image for this fix already release, because I tried today to update to v19.0.0 using vitess/lite:v19.0.0 and still get the issue when performing the backup.

@GrahamCampbell
Copy link
Contributor

No, the 19.0.0 image is for the 19.0.0 release as far as I understand. The fix will be in the 20.0-dev images and the 19.0.1 image when it is released in the future.

@marf
Copy link

marf commented Mar 13, 2024

I see. Hope a 19.0.1 version will be released soon with this fix because our backup system does not work anymore since the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@mattlord mattlord mattlord approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

Assignees
No one assigned
Labels
Backport to: release-19.0 Needs to be back ported to release-19.0 Component: Backup and Restore Type: Bug
Projects
None yet
Milestone
v20.0.0
Development

Successfully merging this pull request may close these issues.

Bug Report: Backup: runtime error on v19.0.0
5 participants
@dbussink @frouioui @marf @GrahamCampbell @mattlord